Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds test matrix for grpc parsing #41

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

elena-kolevska
Copy link
Contributor

This PR adds a matrix that serves as a guideline for implementing the parsing of grpc endpoints, as well as a collection of test cases for the parsing unit tests.

Signed-off-by: Elena Kolevska <[email protected]>
artursouza
artursouza previously approved these changes Oct 22, 2023
yaron2
yaron2 previously approved these changes Oct 22, 2023
shubham1172
shubham1172 previously approved these changes Oct 23, 2023
Signed-off-by: Elena Kolevska <[email protected]>
Copy link
Contributor

@mukundansundar mukundansundar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good. Just had one question.

0008-S-sidecar-endpoint-tls.md Outdated Show resolved Hide resolved
artursouza
artursouza previously approved these changes Mar 19, 2024
@artursouza artursouza merged commit b4a6d7f into dapr:main Mar 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants